fix: prevent double loading spinners#612
Open
Aditya9985 wants to merge 1 commit intoformio:master_oldfrom
Open
fix: prevent double loading spinners#612Aditya9985 wants to merge 1 commit intoformio:master_oldfrom
Aditya9985 wants to merge 1 commit intoformio:master_oldfrom
Conversation
When using a recent version of this library and @formio/js, two loading spinners were displayed for a single form. This was caused by both libraries showing their loading indicators simultaneously. The fix: 1. Added a default template configuration that sets a single loading indicator 2. Initialize the template on library import to ensure it's set before Forms render Fixes formio#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a recent version of this library and @formio/js, two loading spinners were displayed for a single form. This was caused by both libraries showing their loading indicators simultaneously.
This PR fixes the issue by:
The solution:
templates.tsfile that sets up the default template configurationTo test:
<Form src="https://examples.form.io/example" />Fixes #590